getredash/redash

Allow name and email for user added by Remote User Auth to be different

Open

#1,648 创建于 2017年3月2日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)Python (24,845 star) (4,236 fork)batch import
Backendenhancementhelp wanted

描述

Issue Summary

I'm trying to use Active Directory LDAP through remote_user_auth module. Currently there is no way to set different redash user name from mail address. So now my redash user accounts have mail address for both name and mail. Also, if user logs in with just the username or username@domain, the mail address is not correct and the alarm mail won't work.

Technical details:

To solve this, I guess we have to add another environment variable besides REMOTE_USER_HEADER.

Does it make sense to you to add variable like REMOTE_MAIL_HEADER, and use it like

name = REMOTE_USER_HEADER
email = REMOTE_MAIL_HEADER || REMOTE_USER_HEADER
create_and_login_user(current_org, name, email)

instead of

email = REMOTE_USER_HEADER
create_and_login_user(current_org, email, email)
  • Redash Version:Current Head
  • Browser/OS:Chrome
  • How did you install Redash:Docker

贡献者指南

技术栈
python
领域
authenticationbackend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic Python knowledgefamiliarity with Redash authentication
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
The issue proposes adding a new environment variable REMOTE MAIL HEADER to separate the user's name and email. Start by exploring the remote user auth module in the Redash codebase (likely under redash/authentication/). Review the current implementation of create and login user and how REMOTE USER HEADER is used. Then, implement the change to allow optional REMOTE MAIL HEADER, falling back to REMOTE USER HEADER for email. Update documentation and environment variable configuration accordingly. The issue's comment #1648 provides a clear code snippet to guide the implementation.