geoman-io/leaflet-geoman

Types fix (for crucial for react-leaflet users)

Open

#1,515 创建于 2024年9月19日

在 GitHub 查看
 (6 评论) (0 反应) (0 负责人)JavaScript (1,933 star) (404 fork)batch import
help wantedtypescript

描述

Hey! I'm using the free version with react-leaflet, and all seems to work quite well but there is one main problem which is types of event handlers. The type definitions for pm event is on interface Evented, while for react-leaflet users, the event handler's prop type (which are passed to each layer's component) are inferred LeafletEventHandlerFnMap. So far, I have built my own leaflet.d.ts file to extend the type infer to match what geoman is adding. I'd for it to come by default or listen to other possible solutions from the community

贡献者指南

技术栈
javascripttypescriptreact
领域
developer experiencefrontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
TypeScriptReact Leaflet
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Check the existing type definitions in the repository, particularly the Evented interface and the type maps for event handlers. Look at how react leaflet's type inference works for leaflet event handlers. The goal is to extend the existing PM event types to be included in the default EventHandlerFnMap for react leaflet compatibility. See comments in issue #1515 for user provided workaround. Files to examine: likely src/types.ts or similar typings files.