gajus/babel-plugin-react-css-modules

Classnames have trailing whitespace when spread is used

Open

#262 创建于 2019年6月30日

在 GitHub 查看
 (3 评论) (4 反应) (0 负责人)JavaScript (2,044 star) (176 fork)batch import
enhancementhelp wanted

描述

Example: JSX:

<div styleName="classA classB" {...someProps} />

Output:

<div className="classA classB " />

No trailing whitespace is added when spread is not used.

Seems like a small issue, but it breaks snapshots or className checks in tests when upgrading.

贡献者指南

技术栈
javascriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic JavaScriptReact knowledgeUnderstanding of Babel plugins
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Investigate the babel plugin react css modules source code, particularly the part that handles JSX spread attributes. Look at how styleName is converted to className and identify where trailing whitespace is added. The issue is likely in the string concatenation logic. Check the test files for existing tests and consider adding a test case for spread attributes.
Classnames have trailing whitespace when spread is used · gajus/babel-plugin-react-css-modules#262 | Good First Issue