frintjs/frint

Possible race condition issue in `streamProps`

Open

#382 创建于 2017年11月28日

在 GitHub 查看
 (0 评论) (2 反应) (0 负责人)JavaScript (37 fork)batch import
buggood first issuehelp wanted

仓库指标

Star
 (746 star)
PR 合并指标
 (30 天内没有已合并 PR)

描述

Current situation

We ship streamProps helper function from frint-component-utils package, which allows combining values from various sources and then generate a single observable of props.

It uses concatMap operator from RxJS internally.

Possible bug

There is a possibility that with concatMap, we will have some race condition issue.

It is advised to use switchMap instead.

What to do

  • Write unit tests proving there is a race condition issue with streamProps
  • If there is, replace concatMap usage with switchMap without breaking the API

贡献者指南