frintjs/frint

Possible race condition issue in `streamProps`

Open

#382 创建于 2017年11月28日

在 GitHub 查看
 (0 评论) (2 反应) (0 负责人)JavaScript (746 star) (37 fork)batch import
buggood first issuehelp wanted

描述

Current situation

We ship streamProps helper function from frint-component-utils package, which allows combining values from various sources and then generate a single observable of props.

It uses concatMap operator from RxJS internally.

Possible bug

There is a possibility that with concatMap, we will have some race condition issue.

It is advised to use switchMap instead.

What to do

  • Write unit tests proving there is a race condition issue with streamProps
  • If there is, replace concatMap usage with switchMap without breaking the API

贡献者指南

技术栈
javascript
领域
frontendtesting
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
RxJSunit testingfrintstreamProps
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
First, locate the `streamProps` function in the `frint component utils` package (likely in a file like `packages/frint component utils/src/streamProps.ts`). Write unit tests that reproduce a race condition scenario by subscribing to multiple observables with delayed emissions. If a race condition is confirmed, replace the internal `concatMap` operator with `switchMap` and ensure existing tests and the API remain intact. Check the existing test suite for guidance.