frintjs/frint

frint-react: Empty Component when Region is empty

Open

#216 创建于 2017年6月2日

在 GitHub 查看
 (3 评论) (1 反应) (0 负责人)JavaScript (746 star) (37 fork)batch import
featuregood first issuehelp wantedminor

描述

Current situation

Right now, when a Region has no Apps to render, it just remains empty.

It would be useful if we can pass some default Component to render in those cases.

Proposed API

import EmptyRegionContent from '../components/EmptyRegionContent';

<Region name="sidebar" empty={EmptyRegionContent} />

If the sidebar region is empty, it would render EmptyRegionContent component by default.

贡献者指南

技术栈
javascriptreact
领域
frontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Reactfrint basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Look into the Region component in the frint react package. Understand how it currently renders apps. Implement an 'empty' prop that accepts a React component and renders it when no apps are provided. Ensure to add unit tests for the new functionality. Check if there are any existing TypeScript definitions that need updating.
frint-react: Empty Component when Region is empty · frintjs/frint#216 | Good First Issue