fossasia/visdom

Adding support for alpha channels

已关闭

#694 创建于 2020年1月2日

在 GitHub 查看贡献者指南
 (4 条评论) (0 个反应) (0 位负责人)Python (1,152 个派生)batch import
enhancementhelp wanted

仓库指标

星标
 (9,831 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

Currently, this project supports displaying greyscale and RGB images. However, many digital images also contain an alpha channel, and it would be nice to display images as RGBA, rather than converting them to RGB.

My initial investigation shows that simply changing the depth of the first axis from 3 to 4 in https://github.com/facebookresearch/visdom/blob/master/py/visdom/__init__.py#L1268 allows for proper display of RGBA images. Grayscale and RGB images would need to be converted to RGBA by adding a 'full' alpha channel.

Changing only the line as described above, and setting the background of the windows to green gives the following result: image

贡献者指南

研究方向
The issue suggests modifying `py/visdom/ init .py` at line 1268 to change the depth of the first axis from 3 to 4. Additionally, grayscale and RGB images must be converted to RGBA by adding a full alpha channel. The existing code and image loading logic should be reviewed to ensure compatibility. No linked PRs or assignees, so the work is open.
技术栈
pythonnumpy
领域
data
议题类型
功能
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 小时
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
较久未更新
清晰度议题是否清楚说明期望改动、验收标准和下一步。
清晰
前置要求
PythonNumPybasic git workflow
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85