foam-framework/foam

Should clone() run initializers? ... probably by issuing a create()?

Open

#425 创建于 2015年10月8日

在 GitHub 查看
 (1 评论) (0 反应) (1 负责人)JavaScript (789 star) (57 fork)batch import
bughelp wantedquestion

描述

@jacksonic, @adamvy, and I were discussing this today. We've noted that dynamicValue() breaks init() doesn't run on objects that come out of a DAO that produces clones. We are pretty confident that this is because clone() doesn't actually create() a new object, and that it probably should.

@kgrgreer, can you offer your thoughts on this?

贡献者指南

技术栈
javascript
领域
backend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
needs maintainer response
清晰度议题是否清楚说明期望改动、验收标准和下一步。
needs investigation
前置要求
Understanding of Foam object modelKnowledge of clone() and create() methods
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Investigate the clone() method implementation in the FOAM framework, likely in files related to object creation and initialization. Review the discussion in the issue and any linked comments. Look at the dynamicValue() function to understand how it breaks when init() is not run. Consider modifying clone() to call create() under the hood to ensure initializers run. Consult maintainer @kgrgreer for acceptance criteria.
Should clone() run initializers? ... probably by issuing a create()? · foam-framework/foam#425 | Good First Issue