firefox-devtools/profiler

Clean up the fallback label code for FileIO markers

开放

#3,131 创建于 2021年1月15日

 (3 条评论) (0 个反应) (0 位负责人)TypeScript (486 个派生)auto 404
code maintenancehelp wantedmarkersneeds gecko patch

仓库指标

星标
 (1,515 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

In the following code, we have some fallback code dedicated to FileIO markers: https://github.com/firefox-devtools/profiler/blob/c87e4e9127aa1f2e423dd81712cc4f829cf24e6f/src/profile-logic/marker-schema.js#L279-L289

This doesn't seem necessary nowadays as this could be implemented as a schema. The work here is:

  1. implement in gecko the schema that does this. (or check that it's implemented)
  2. remove the aforementioned fallback code
  3. add migration steps to both gecko and processed profile versioning to add the data to marker schemas from older profiles.
  4. possibly add tests if there's some missing for this case

┆Issue is synchronized with this Jira Task

贡献者指南