filamentphp/filament

Grid table border on hover/select in dark mode

Open

#7,784 创建于 2023年8月15日

在 GitHub 查看
 (1 评论) (0 反应) (1 负责人)PHP (30,736 star) (4,162 fork)batch import
bughelp wantedlow priorityneeds more infoui

描述

Package

filament/tables

Package Version

v3.0.19

Laravel Version

v10.18.0

Livewire Version

v3.0.0-beta.7

PHP Version

PHP 8.2

Problem description

Just a follow up. PR #7636 introduced a slight difference between classic tables and grid tables hover/select appearance in dark mode.

before

after

Expected behavior

Both "tables" should look the same.

Steps to reproduce

  • Install Filament v3.0.18
  • Create a table with and without Grid Layout (e.g. Stack/Split columns)
  • Upgrade to Filament v3.0.19 (which includes the mentioned PR).

Reproduction repository

https://github.com/ajnsn/filament-demo-borders

Relevant log output

No response

贡献者指南

技术栈
csstailwindcss
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
CSSTailwind CSS
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Investigate the changes introduced in PR #7636 regarding grid table hover/select styles in dark mode. Compare the CSS classes applied to grid tables and classic tables. The issue likely lies in the filament tables package's CSS, specifically in files related to table row hover states. Ensure that grid tables also receive the appropriate border highlight on hover/select in dark mode, similar to classic tables.