feathr-ai/feathr

Add guardrails for materialize different keys

Open

#529 创建于 2022年7月29日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)Scala (1,929 star) (244 fork)batch import
good first issuepython

描述

In theory, we can't materialize features of different keys into same online table as tables are always keyed by same key.

In the documentation, we do warn users not to materialize different keys to same table.

Right now, if users materialize features to the same table, a random group of the same key will materialize to the table. The other different groups will be discarded. The documentation is not fool-proof enough, so we should throw exception when users do this.

The code to modify is: https://github.com/linkedin/feathr/blob/main/feathr_project/feathr/client.py#L558

贡献者指南

技术栈
python
领域
backenddata
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Python basicsFeathr client understanding
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
The issue points to line 558 in feathr project/feathr/client.py. The task is to add a guardrail that raises an exception when users try to materialize features with different keys into the same online table. Look at the current materialize method and add a check for key consistency. Consider writing a unit test to verify the behavior.