Add type check for all the registry tags · feathr-ai/feathr#256

(8 评论) (0 反应) (1 负责人)Scala (1,929 star) (244 fork)batch import

good first issuehelp wanted

描述

Currently the registry tags are a dictionary format like this:

{"description":"this is a test feature"}

but user could easily do something else like

{"description", "this is a test feature"}

and the object will not be serialized as it's not a valid python dict. We should add a type check for that to avoid those kind of errors.

技术栈: python
领域: backenddata
议题类型: feature
难度: 2
预计时间: under 1 hour
活动状态: blocked
清晰度: clear
前置要求: Basic Python
新手友好度: 85
研究方向: The registry tags are expected to be a Python dictionary. To add a type check, locate the code that processes registry tags (likely in a Python file related to feature definition or registry client). Implement a validation function that uses isinstance to ensure the tags input is a dict, and raise a TypeError or ValueError with a descriptive message if it is not. Ensure existing tests pass and consider adding a test for the invalid case.