facebookresearch/metaseq

Convert string matches to enum comparison if possible

Open

#311 创建于 2022年8月20日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)Python (6,195 star) (701 fork)batch import
better-engconfigenhancementgood first issue

描述

We have a lot of places where we do string matching, like:

https://github.com/facebookresearch/metaseq/blob/88ae968e679efbe84a8c246d1177852facfc43a2/metaseq/tasks/streaming_language_modeling.py#L339

or

https://github.com/facebookresearch/metaseq/blob/88ae968e679efbe84a8c246d1177852facfc43a2/metaseq_cli/train.py#L96

which can all be found via: ag "== \"" --py.

Convert these all to comparing against enums if possible.

贡献者指南

技术栈
python
领域
backend
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
PythonEnum types
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
The issue requests converting string comparisons to enum comparisons across the codebase. Start by identifying all string comparisons using `ag "== \"" py` as suggested in the issue. Relevant files include metaseq/tasks/streaming language modeling.py and metaseq cli/train.py. Review existing enum definitions in the codebase, then systematically replace string literals with enum members. Consider creating a unified enum for commonly compared strings.