描述

🐛 Bug

Almost identical issue to: #1071 except on a new edge case. Configen will create fields typed with Optional[str], but if there's a default value which is a str type, it will not include it in quotes. We should also test other supported Type hint permutations.

Ex: Generates the field weights_summary: Optional[str] = top instead of the desired: weights_summary: Optional[str] = "top"

To reproduce

git clone https://github.com/romesco/hydra-lightning
configen --config-dir=configen/conf

Will create PR similar to #1072 for fix.

System information

Hydra Version : configen==0.9.0dev4
Python version : 3.8.6
Virtual environment type and version : pyenv-virtualenv 1.2.20
Operating system : Ubuntu 18.04

贡献者指南

技术栈: python
领域: tooling
议题类型: bug
难度: 2
预计时间: under 1 hour
活动状态: fresh
清晰度: clear
前置要求: 无
新手友好度: 80
研究方向: The bug is in the configen code generation, specifically when handling Optional[str] fields with default string values. The fix should ensure that string defaults are quoted. Look at the code that generates the field definition, likely in the configen source code. Reference PR #1072 which fixed a similar issue for non Optional str defaults. The change should be localized to the string formatting logic for default values when the type is Optional[str].