facebookresearch/fmmax

Better type checking in `eigensolve_isotropic_media`

开放

#53 创建于 2023年10月31日

 (0 条评论) (0 个反应) (0 位负责人)Jupyter Notebook (15 个派生)auto 404
enhancementgood first issue

仓库指标

星标
 (149 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

Currently, if the wavelength parameter within eigensolve_isotropic_media is passed as a float, rather than a jax array, then it throws an obscure error (not directly pointing to the wavelength parameter itself).

It would be good to either

  • explicitly allow for float values and do the necessary conversions under the hood.
  • assert a type up front and throw an error describing why this needs to be the case.

贡献者指南