facebookresearch/ParlAI

ParlaiParser.add_argument should support no_save and no_override

Open

#2,177 创建于 2019年11月19日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)Python (10,371 star) (2,089 fork)batch import
EnhancementH1 2020Help WantedMinordonotreap

描述

Depends on #2172.

  • If no_save is True, then the option is not saved with the opt.
  • If no_override is True, then the parser will throw a hard error if the value on disk is not what's loaded. This one might have to wait a bit longer.

贡献者指南

技术栈
python
领域
developer experiencecli
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic knowledge of PythonFamiliarity with ParlAI configuration system
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
This issue depends on #2172 which should be resolved first. After that, the implementation involves adding two boolean flags (no save and no override) to the add argument method in ParlaiParser. Likely file: parlai/core/params.py. The no save flag should prevent the option from being saved in opt; no override should cause a hard error if there's a mismatch with saved values. Check the discussion in #2172 for implementation patterns.