facebookexperimental/Recoil

Allow greater control in errorSelector

开放

#637 创建于 2020年10月7日

 (1 条评论) (0 个反应) (0 位负责人)JavaScript (1,151 个派生)batch import
enhancementhelp wanted

仓库指标

星标
 (19,428 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

errorSelector currently takes a custom message as a parameter and passes that message into a newly constructed Error object.

Current: errorSelector("This is my error message")

I believe that asking for an Error object as the argument instead of a message would allow for greater control and flexibility.

Proposed: errorSelector(new Error("This is my error message")) Proposed:

errorSelector(() => { 
  let e = new Error(); 
  e.name = "AuthError"; 
  e.message = "User is not logged in"; 
  return e; 
})

If this is functionality that we would like to see in Recoil, I would love to submit a PR on this.

贡献者指南