facebookexperimental/Recoil

Memory leak when using atomFamily/selectorFamily

Open

#366 创建于 2020年6月19日

在 GitHub 查看
 (22 评论) (13 反应) (1 负责人)JavaScript (19,428 star) (1,151 fork)batch import
help wantedperformance

描述

Hello there,

The resources created by atomFamily and selectorFamily are not being properly freed when the specific key changes or if the component using the related RecoilState<T> unmounts.

Since I believe that memory management isn't properly implemented yet, both utils should be marked as _UNSAFE.

https://codesandbox.io/s/cranky-booth-penix?file=/src/App.js

贡献者指南

技术栈
javascriptreact
领域
frontendperformance
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
over 1 week
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ReactRecoilMemory management in JavaScript
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
20
研究方向
The issue describes a memory leak in atomFamily and selectorFamily where resources are not freed when keys change or components unmount. Review the Recoil source code in the src directory (e.g., src/shared/AtomFamily.js or src/shared/SelectorFamily.js) to understand how atoms and selectors are created and stored. Check existing comments and the linked CodeSandbox for reproduction steps. Note that the issue has an assignee, so reach out to them or maintainers before starting work.