facebookexperimental/Recoil

[Performance] Short-circuit set recoil state if the value is unchanged

Open

#1,927 创建于 2022年7月30日

在 GitHub 查看
 (7 评论) (1 反应) (0 负责人)JavaScript (19,428 star) (1,151 fork)batch import
help wantedperformance

描述

It seems that the current implementation of setting recoil state can be further improved when the value is the same as the current value. In this case, we don't have to go through all the enchilada and more importantly don't have to call setState in the end, which is not exactly cost free. I have observed major performance hit thanks to that. I have to cache the previous value myself and do the equality check before calling set recoil state when recoil has all the knowledge to that.

贡献者指南

技术栈
javascriptreact
领域
performancefrontend
议题类型
performance
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaScriptReactRecoil fundamentals
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Look at the Recoil source code related to state updates, specifically the `setRecoilState` function. Identify where the state is updated and add an equality check to short circuit if the value is unchanged. Consider using a shallow comparison for objects. Check existing comments for additional context.
[Performance] Short-circuit set recoil state if the value is unchanged · facebookexperimental/Recoil#1927 | Good First Issue