facebookarchive/prepack

Deterministic timeout

Open

#719 创建于 2017年6月10日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)JavaScript (14,268 star) (520 fork)batch import
enhancementhelp wantedinterpreter

描述

Picking up a theme from #472 and #520 which warrants its own issue: It seems useful to reimplement the RealmOptions.timeout heuristic by counting evaluation operations, over the current nondeterministic approach of measuring wall-clock time.

@NTillmann per your earlier comments I gather you think Environment.prototype.evaluate would the right place to increment and check this proposed counter? If so, seems straightforward enough and I'll give it a go.

贡献者指南

技术栈
javascript
领域
toolingperformance
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
familiarity with Prepack codebaseJavaScript fundamentals
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Review the discussions in issues #472 and #520 for context. Examine the file where Environment.prototype.evaluate is defined (likely in src/runtime/environment.js). Increment a counter in evaluate and check against a limit. Ensure the implementation matches the existing RealmOptions configuration.