facebookarchive/prepack

Create smoke-test for prepack-node

Open

#693 创建于 2017年6月1日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (14,268 star) (520 fork)batch import
help wantedtest needed

描述

A recent change to the code resulted in PrepackFile throwing an exception whenever it's invoked (see fix in #691 ), but that was not detected by any of our tests. We should add a basic smoke test for each of the exported functions from prepack-node (prepackStdin, prepackFile, and prepackFileSync) to allow for such clear-cut breaks to be automatically caught by testing.

贡献者指南

技术栈
javascriptnodejs
领域
testing
议题类型
test
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
无
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
20
研究方向
The issue requests adding smoke tests for the three exported functions of prepack node: prepackStdin, prepackFile, and prepackFileSync. A previous fix (#691) was not caught by tests, so these tests are needed. The code is likely in a prepack node directory. The contributor should set up a testing environment and write basic tests that call each function to ensure they don't throw exceptions.