facebookarchive/prepack

realm.$TemplateMap is persistent throughout effects

Open

#2,129 创建于 2018年6月18日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (14,268 star) (520 fork)batch import
abstractbughelp wantedinterpreterlevel 2 (easy)

描述

Using ES2015 tagged template literals makes use of a $TemplateMap on the realm. When we evaluateForEffects and create a tagged template inside some effects, then revert the effects, it's expected that the newly created array objects in the template map are also stored on effects and properly reverted.

贡献者指南

技术栈
javascript
领域
build systemperformance
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Understanding of JavaScript template literalsFamiliarity with prepack's effect system
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
20
研究方向
The issue is about tagged template literals and the `$TemplateMap` on the realm. Investigate the effect system in prepack, specifically how effects are created and reverted when evaluating tagged templates. Look at the relevant source files in the repository, likely in the effects or realm modules, to understand how `$TemplateMap` entries are managed. There are no comments or linked PRs, so the fix requires a thorough understanding of the codebase.