facebookarchive/prepack

Review all FatalError throws

Open

#2,020 创建于 2018年5月24日

在 GitHub 查看
 (2 评论) (2 反应) (0 负责人)JavaScript (14,268 star) (520 fork)batch import
bughelp wanted

描述

I've seen a few code snippets like this:

    // todo: emit a diagnostic messsage
    throw new FatalError();

This is problematic for two reasons:

  1. User doesn't get any useful feedback.
  2. Worse, on the command-line it will show up as an internal error, because there must not be a FatalError without a CompilerDiagnostic thingy having been issued.

Concrete work items:

  1. Review all places in the code where a FatalError is thrown, and make sure that a corresponding CompilerDiagnostic thingy was issued before.
  2. Rethink best practices, as it is too easy to create mismatches between FatalError and CompilerDiagnostic (how did this get past code review?).

贡献者指南

技术栈
javascript
领域
developer experiencetooling
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Understanding of FatalError and CompilerDiagnostic in prepack
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Review all occurrences of `throw new FatalError()` in the prepack codebase. For each, check if a `CompilerDiagnostic` is emitted before the throw. The issue mentions that some places have a TODO comment without a diagnostic. Look at the linked PRs or comments for any prior discussion. Files likely include compiler error handling modules.