facebookarchive/prepack

Lexical declarations in top-level lexical scope are omitted

Open

#1,905 创建于 2018年5月8日

在 GitHub 查看
 (3 评论) (1 反应) (0 负责人)JavaScript (520 fork)batch import
bughelp wantedlevel 2 (easy)serializer

仓库指标

Star
 (14,268 star)
PR 合并指标
 (30 天内没有已合并 PR)

描述

const f = 0; is considered by Prepack to be totally dead. But it's not: the top-level lexical scope is shared across scripts, just below the global scope. So while that may not be a global declaration, in that it does not create a property of the global object, it is available to other code on the page just as if it had been var instead of const; other scripts can write console.log(f) to print 0. In that sense it is not safe to eliminate.

This may or may not be a bug, depending on your perspective. I'm just not sure what things prepack considers dead: { const f = 0; } definitely is, var f = 0; definitely isn't, but this is kind of in-between.

贡献者指南