facebookarchive/prepack

Rewrite reportIntrospectionError calls

Open

#1,898 创建于 2018年5月8日

在 GitHub 查看
 (8 评论) (0 反应) (0 负责人)JavaScript (520 fork)batch import
enhancementhelp wanted

仓库指标

Star
 (14,268 star)
PR 合并指标
 (30 天内没有已合并 PR)

描述

Once upon a time, Prepack didn't have a real error-handling story besides just throwing an exception. From this time, there are still a ton of reportIntrospectionError calls in the code base.

They should all be rewritten, one by one (separate pull-requests, please) into something like the following.

    let error = new CompilerDiagnostic("appropriate error message", referenceToSourceLocation, "PPxxxx", "FatalError");
    realm.handleError(error);
    throw new FatalError();

Where PPxxxx should be the next currently unused error code; check https://github.com/facebook/prepack/wiki/Prepack-diagnostics for all currently defined error code.

  • Create a new wiki page with the PP error number as its name.
  • Add a link to it from the page that lists all error numbers.

贡献者指南