facebookarchive/prepack

Make Prepack heap graph visualization to be consistently with different serialization options

Open

#1,309 创建于 2018年1月2日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (14,268 star) (520 fork)batch import
bughelp wantedwebsite

描述

Currently, Prepack heap graph visualization is based on the default Prepack mode so it may diverge from the real generated code when options are applied. For example, when --inlineExpressions is applied, many objects are inlined into its parent object so there is no identifier generated for it while heap visualization still shows their identifiers which is confusing.(Not sure what to show though).

Here are some options that may change the graph but not well tested:

  1. --inlineExpressions.
  2. --debugNames
  3. --additionalFunctions.
  4. --react

For this issue, we should a least fix for "--inlineExpressions" since it is default on website. Also, we should make heap visualization feature is disabled when "--additionalFunctions/--react" is specified since we haven't tested it yet.

贡献者指南

技术栈
javascript
领域
tooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Prepack serialization optionsHeap graph visualization code
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
20
研究方向
Start by examining the heap graph visualization code in the Prepack repository. Look for the module responsible for generating the visualization and see how it currently uses serialization options, particularly inlineExpressions. Check the options parsing code to understand how to conditionally enable/disable features. Also, review any existing tests for visualization consistency. Since the repository is archived, consider whether changes are still desired, but for this issue, the goal is to make the visualization reflect the actual output of different options.