facebookarchive/prepack

Produce abstract string for JSON.stringify(concreteObject) if properties are abstract

Open

#1,012 创建于 2017年9月27日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (14,268 star) (520 fork)batch import
abstractbughelp wantedtest needed

描述

If a concrete object has properties with abstract values, the interpretation of SerializeJSONProperty in src/intrinsics/ecma262/JSON.js will either fail obscurely or do the wrong thing, such as returning undefined.

It would be better to first check for this case and then go into the JSON.stringify part of the special case code for dealing with JSON.parse(JSON.stringify(abstractObject)).

贡献者指南

技术栈
javascript
领域
toolingbuild system
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
understanding of JSON.stringifyfamiliarity with the prepack codebase
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
25
研究方向
The issue is in the archived facebookarchive/prepack repository, specifically in src/intrinsics/ecma262/JSON.js. The bug occurs in SerializeJSONProperty when a concrete object has abstract property values. To fix, first detect this case, then handle it similarly to the special case for JSON.parse(JSON.stringify(abstractObject)). Since the repo is archived, contributions may not be accepted, but the fix can be studied for learning.