facebookarchive/draft-js

Do not default to LTR for empty editors

Open

#634 创建于 2016年9月7日

在 GitHub 查看
 (6 评论) (0 反应) (0 负责人)JavaScript (22,554 star) (2,646 fork)batch import
bughelp wanted

描述

Do you want to request a feature or report a bug?

Reporting a bug, I guess.

What is the current behavior?

On an empty Draft.js field, the first block has a public-DraftStyleDefault-ltr class and the caret is on the left side. This is before the first character is typed. This default does not make sense for an RTL environment, where everything else is RTL except for the caret.

What is the expected behavior?

Not setting a direction when no content is available. It would default to the parent direction, which is a sensible default.

Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js?

Draft 0.8.1, Chrome 52 and Safari 9.1.3, OS X 10.11.16. Didn’t check the older versions.

I’d be happy to work on a PR if you agree with the suggestion.

贡献者指南

技术栈
javascriptreact
领域
frontendaccessibility
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic knowledge of Draft.js editor internalsUnderstanding of text direction handling in CSS
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
The repository (facebookarchive/draft js) is archived, so no active development is expected. However, if one were to fix this, the issue is about the default LTR class applied to empty editor blocks. Investigate the logic in src/component/contents/DraftEditorBlock.react.js or similar files where block direction is determined. The fix would likely involve not applying a direction class when the block has no content, allowing the parent direction to take effect. Check for any existing PRs or comments that discuss the implementation.