facebookarchive/draft-js

Indenting list block of one type inside the other

Open

#443 创建于 2016年6月5日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)JavaScript (22,554 star) (2,646 fork)batch import
enhancementhelp wanted

描述

If I create a OL of 2 items and change depth of 2nd item to 2, like this:

1. ITEM1
      2. ITEM2

If I change type of 2nd item to UL it looses it depth:

1. ITEM1

2. ITEM2

But now if I try to indent second item, it works

1. ITEM1

    2. ITEM2

While indenting its checked that block above is list, but its not checked if its list of same type. Also, please find gif attached. I can create a PR for the fix.

贡献者指南

技术栈
javascriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic understanding of ReactFamiliarity with Draft.js editor internals
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Investigate the Draft.js list indentation logic, specifically how block types are changed and depth is maintained. Look at the source files handling OL and UL block rendering, especially the 'RichTextEditor' or 'EditorState' utilities. The bug occurs when changing a list item type from OL to UL and the depth resets. Focus on the function that updates block type and its handling of depth. Examine the code in 'lib/EditorState.js' or similar that processes block metadata during type changes. The fix likely involves ensuring that the depth property is preserved when only the type field is modified.