facebookarchive/draft-js

Improve style by removing boolean param in `getCharacterRemovalRange.js`

Open

#1,116 创建于 2017年4月3日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)JavaScript (22,554 star) (2,646 fork)batch import
enhancementgood first issue

描述

A recent change added two boolean flag params to getCharacterRemovalRange.js. Boolean params generally make code less readable and maintainable - this is not worth blocking a PR at this time, but it would be great to update this file and the callsites to call two methods instead of passing in different boolean params.

贡献者指南

技术栈
javascriptreact
领域
frontend
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ReactJavaScriptfamiliarity with draft js codebase
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Review the changes in PR #1108 that added boolean params to getCharacterRemovalRange.js. Then refactor the function to split into two methods (e.g., for forward and backward deletion) and update all callsites. Ensure existing tests pass and add tests if needed. See issue comments for discussion.
Improve style by removing boolean param in `getCharacterRemovalRange.js` · facebookarchive/draft-js#1116 | Good First Issue