facebookarchive/atom-ide-ui
在 GitHub 查看Allow code format providers to return null to 'fall through'
Open
#26 创建于 2017年9月13日
code formatenhancementhelp wanted
仓库指标
- Star
- (937 star)
- PR 合并指标
- (30 天内没有已合并 PR)
描述
Code format providers are currently forced to return something: https://github.com/facebook-atom/atom-ide-ui/blob/master/modules/atom-ide-ui/pkg/atom-ide-code-format/lib/types.js
However, this makes it difficult to have multiple formatting providers for the same document, since we only use the one with the highest priority.
Instead, we should use ProviderRegistry.getAllProvidersForEditor (e.g. on https://github.com/facebook-atom/atom-ide-ui/blob/master/modules/atom-ide-ui/pkg/atom-ide-code-format/lib/CodeFormatManager.js#L257) and take the first one with a non-nullable result.
cc @damieng