facebook/relay

[modern] Same field queried with different arguments overwrites proper results

Open

#2,024 创建于 2017年8月9日

在 GitHub 查看
 (2 评论) (1 反应) (0 负责人)Rust (18,930 star) (1,874 fork)batch import
bughelp wantedwontfix

描述

Given query:

query UsersStatisticsQuery(
  $monthAgo: DateTime!,
  $twoMonthsAgo: DateTime!,
  $threeMonthsAgo: DateTime!,
  $fourMonthsAgo: DateTime!,
  $fiveMonthsAgo: DateTime!
  $sixMonthsAgo: DateTime!
) {
  root {
    statistics {
      usersUpToNow: users_count
      usersUpToMonthAgo: users_count(registered_before: $monthAgo)
      usersUpToTwoMonthsAgo: users_count(registered_before: $twoMonthsAgo)
      usersUpToThreeMonthsAgo: users_count(registered_before: $threeMonthsAgo)
      usersUpToFourMonthsAgo: users_count(registered_before: $fourMonthsAgo)
      usersUpToFiveMonthsAgo: users_count(registered_before: $fiveMonthsAgo)
    }
  }
}

in GraphiQL it gets properly returned:

{
  "data": {
    "root": {
      "statistics": {
        "usersUpToNow": 1282,
        "usersUpToMonthAgo": 1248,
        "usersUpToTwoMonthsAgo": 1156,
        "usersUpToThreeMonthsAgo": 1071,
        "usersUpToFourMonthsAgo": 968,
        "usersUpToFiveMonthsAgo": 737,
      }
    }
  }
}

However, in component:

usersUpToNow: 1282
usersUpToMonthAgo: 1248
usersUpToTwoMonthsAgo: 1248
usersUpToThreeMonthsAgo: 1248
usersUpToFourMonthsAgo: 1248
usersUpToFiveMonthsAgo: 1248

Well… I think it shouldn't have duplicated wrong values. react-relay@^1.1.0

贡献者指南

技术栈
reactgraphql
领域
api
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Familiarity with GraphQLBasic understanding of Relay
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Investigate how Relay's store handles field arguments and aliases. The bug likely occurs when the same field (e.g., 'users count') is queried with different arguments but aliased differently, causing cache key collision. Look at the normalization code in Relay's source, particularly how arguments are incorporated into the data ID. Check if the issue is related to the argument key generation in the relay runtime.