facebook/prop-types

Return value from checkPropTypes?

Open

#169 创建于 2018年3月1日

在 GitHub 查看
 (6 评论) (31 反应) (0 负责人)JavaScript (4,379 star) (389 fork)batch import
help wanted

描述

Is there a good reason not to return false if checkPropTypes fails any of the validations? I can't think of one myself. If no one disagrees I can do a PR.

This would be useful for those of us that want to use checkPropTypes for our own validation needs outside of React.

贡献者指南

技术栈
javascript
领域
frontenddeveloper experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaScriptNode.jsprop types library usage
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
The issue requests modifying `checkPropTypes` to return `false` when validation fails. Start by examining the current implementation of `checkPropTypes` in the source code (likely in `checkPropTypes.js`). Understand how it currently logs warnings and that it returns `undefined`. To implement, you would change the function to return a boolean indicating success/failure while maintaining backward compatibility. There are 6 comments in the issue that may provide additional context; review them for potential pitfalls or preferred approaches. No pull request is linked, so this is your chance to contribute a first PR.