facebook/prop-types

React Portals can't be validated with prop-types

Open

#167 创建于 2018年3月1日

在 GitHub 查看
 (4 评论) (17 反应) (0 负责人)JavaScript (4,379 star) (389 fork)batch import
bughelp wanted

描述

PropTypes.node is not accepting element, created by React.createPortal as valid

Is it possible to treat element created by React.createPortal as iterator over it's children or treat portal itself as valid node?

贡献者指南

技术栈
reactjavascript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic knowledge of ReactUnderstanding of React PortalsFamiliarity with prop types API
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Investigate the PropTypes.node implementation in the prop types library, specifically the isNode validator. Examine how React Portals are represented (as objects with a $$typeof). Determine if the validator can be extended to treat portals as valid nodes. Consider referencing the React source for createPortal.