facebook/TestSlide

Add constructor input checks for matchers

Open

#233 创建于 2020年9月1日

在 GitHub 查看
 (0 评论) (0 反应) (1 负责人)Python (58 fork)auto 404
Hacktoberfestenhancement

仓库指标

Star
 (147 star)
PR 合并指标
 (PR 指标待抓取)

描述

When we do:

AnyInstanceOf(not_a_type)

we end up raising an exception not at the constructor, but rather when the comparison is being made, and isinstanceof (at AnyInstanceOf's code) will complain that not_a_type is... not a type.

Let's revisit all matchers & ensure that all of them raise ValueError if the constructor arguments are invalid from the constructor itself.

CC @deathowl

贡献者指南