ethereum/casper

Deploy PURITY_CHECKER and MSG_HASHER with via compile in testing

Open

#159 创建于 2018年5月30日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)Python (685 star) (184 fork)batch import
blockedgood first issue

描述

Issue

PURITY_CHECKER and MSG_HASHER are currently deployed via previously sign txs in the testing framework. This is super opaque and makes it tough to test any changes to purity checker. It is also not how we plan on deploying in the EIP

Proposed implementation

  • ensure msg_hasher and purity_checker source are in the repo
  • compile and deploy dynamically in testing rather than sending a previously sign tx

BLOCKER: #69 and #73. Both of these issues port msg_hasher and purity_checker to vyper LLL so we don't have to introduce serpent as a dependency.

贡献者指南

技术栈
python
领域
testing
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
over 1 week
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Port msg hasher to Vyper LLL (#69)Port purity checker to Vyper LLL (#73)
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
20
研究方向
First, ensure that issues #69 and #73 are completed to port msg hasher and purity checker to Vyper LLL. Then, modify the testing framework to dynamically compile and deploy these contracts instead of using pre signed transactions. Look at the current testing setup in the repository's test files to understand the existing deployment method.