erikringsmuth/app-router

core-animated-pages multiple paths match same app-route

Open

#44 创建于 2014年12月5日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)HTML (608 star) (83 fork)batch import
bugdesign discussionhelp wanted

描述

This is an extension of PR https://github.com/erikringsmuth/app-router/pull/43 from @sohjsolwin.

Example router.

<app-router core-animated-pages transitions="cross-fade-all">
  <app-route path="/first" element="first-page"></app-route>
  <app-route path="/second" element="second-page"></app-route>
  <app-route path="/page/:pageNum" element="third-page"></app-route>
</app-router>

Paths /page/1 and /page/2 will both match the last route. The transition between these two pages won't be animated because setting coreAnimatedPages.selected = 3 doesn't change the page.

This may require a big re-think of the app-router / core-animated-pages implementation...

贡献者指南

技术栈
htmljavascriptweb components
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
needs investigation
前置要求
Understanding of app router routingFamiliarity with core animated pages
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
The issue describes a problem where multiple routes match the same pattern (e.g., /page/1 and /page/2 both match /page/:pageNum) and the transition between them is not animated because the selected index does not change. This is an extension of PR #43, which likely attempted a fix. To resolve, investigate how app router currently selects the matching route and how core animated pages updates its selected index. Consider a reimplementation that triggers animations even when the route pattern matches but parameters change. The comments and PR #43 may contain attempted solutions.
core-animated-pages multiple paths match same app-route · erikringsmuth/app-router#44 | Good First Issue