enzymejs/enzyme

Silently failing tests with JSDOM

Open

#621 创建于 2016年10月3日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (19,979 star) (2,016 fork)batch import
docshelp wanted

描述

This is likely closely related to #543.

My mocha test suite runs after a setup script.

The problem is that examples fail silently if document.defaultView.XMLHttpRequest is assigned to global.XMLHttpRequest.

Similarly, I worked around it with

if (typeof global[property] === 'undefined' && property !== 'XMLHttpRequest') {
  global[property] = document.defaultView[property];
}

I can't really pinpoint the root cause of this, but if nothing else it may be worthwhile to update the JSDOM guide.

贡献者指南

技术栈
javascriptreactnodejs
领域
testingdocumentation
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Basic knowledge of enzymeFamiliarity with JSDOM setup
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
25
研究方向
Investigate the root cause of silent test failures when global.XMLHttpRequest is assigned from JSDOM's document.defaultView. Refer to related issue #543 for additional context. Consider updating the JSDOM usage guide in enzyme's documentation to include the workaround described in the issue.