enzymejs/enzyme

getDerivedStateFromProps called from setState

Open

#2,078 创建于 2019年4月2日

在 GitHub 查看
 (2 评论) (3 反应) (0 负责人)JavaScript (19,979 star) (2,016 fork)batch import
bughelp wanted

描述

Current behavior

getDerivedStateFromProps is being called from within setState, instead of before render, which overwrites the state and is inconsistent with react behavior. Please see attached codesandbox. There is a FloatInput.spec.js file with a unit test to show the behavior.

Expected behavior

getDerivedStateFromProps should be called before render not from setState.

Your environment

https://codesandbox.io/s/vqrm0r0r30

API

  • [x ] shallow
  • mount
  • render

Version

library version
enzyme 3.9.0
react 16.8.3
react-dom 16.8.3
react-test-renderer
adapter (below)

Adapter

  • [x ] enzyme-adapter-react-16
  • enzyme-adapter-react-16.3
  • enzyme-adapter-react-16.2
  • enzyme-adapter-react-16.1
  • enzyme-adapter-react-15
  • enzyme-adapter-react-15.4
  • enzyme-adapter-react-14
  • enzyme-adapter-react-13
  • enzyme-adapter-react-helper
  • others ( )

贡献者指南

技术栈
reactjavascript
领域
testing
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ReactenzymeJavaScript
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Examine the enzyme shallow renderer implementation, specifically how getDerivedStateFromProps is invoked. Review the provided codesandbox (https://codesandbox.io/s/vqrm0r0r30) and the FloatInput.spec.js test file. The issue indicates that getDerivedStateFromProps is called from setState instead of before render. Look at the adapter for React 16 (enzyme adapter react 16) to identify where the lifecycle method is called incorrectly. Ensure the fix aligns with React's behavior where getDerivedStateFromProps should be called during the render phase, not from state updates.