enzymejs/enzyme

React Elements returned by enzyme in v3 are missing context

Open

#1,344 创建于 2017年11月10日

在 GitHub 查看
 (3 评论) (1 反应) (0 负责人)JavaScript (19,979 star) (2,016 fork)batch import
API: shallowhelp wantedv3 bugs

描述

In v2, if you wanted to get the underlying element, it contained the element's context. In v3, there is no context.

I believe for shallow, we just need to add it here https://github.com/airbnb/enzyme/blob/master/packages/enzyme-adapter-react-16/src/ReactSixteenAdapter.js#L224

For mount, it's a few places (in those toTree functions).

I think it'd be nice to have the context on the element though so that it's closer to the real element.

Thoughts?

贡献者指南

技术栈
reactjavascript
领域
frontendtesting
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
React contextEnzyme shallow adapterEnzyme mount toTree
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Examine the shallow rendering adapter in packages/enzyme adapter react 16/src/ReactSixteenAdapter.js around line 224 to understand how elements are constructed. For mount, locate the toTree functions in the same adapter or elsewhere and add context to the returned element. Review any existing discussion in comments for implementation details.