envoyproxy/envoy

CacheFilter: Parse and handle precondition request headers

Open

#9,855 创建于 2020年1月28日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)C++ (5,373 fork)batch import
area/cachehelp wanted

仓库指标

Star
 (27,997 star)
PR 合并指标
 (平均合并 8天) (30 天内合并 378 个 PR)

描述

CacheFilter (#7198) must fully parse and handle precondition request headers (RFC7232): if-match, if-none-match, if-modified-since, if-unmodified-since, and if-range.

This must be fixed before CacheFilter can be appropriate for production deployment.

We currently ignore these headers, which is incorrect, and will result in serving wrong content from cache. As a temporary shortcut, it would be acceptable to instead bypass caching for requests with precondition header. This would reduce cache effectiveness and give clients an easy way to bypass cache, but would never cause incorrect results. With the shortcut, this issue would no longer block production deployment of CacheFilter.

贡献者指南