envoyproxy/envoy

stats: retain Scopes for some amount of time after the last reference to them is dropped, to avoid leaking data when xds removes a scope

Open

#23,619 创建于 2022年10月21日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)C++ (5,373 fork)batch import
area/statsenhancementhelp wantedno stalebot

仓库指标

Star
 (27,997 star)
PR 合并指标
 (平均合并 8天) (30 天内合并 378 个 PR)

描述

Title: When an xDS update removes a cluster, any stats that get updated after the most recent sink or scrape will get dropped when the ScopeSharedPtr held in the cluster gets dropped.

Description:

To avoid this we should delay the destruction of the Scope for some time interval, perhaps a few minutes. We must be careful to accelerate the Scope destruction when the stats store gets destructed (server exit, or unit-test completion).

贡献者指南