envoyproxy/envoy

Why envoy behaves differently when envoy adds an error tag to trace according to HTTP and GRPC status?

开放

#15,883 创建于 2021年4月8日

 (2 条评论) (2 个反应) (0 位负责人)C++ (5,373 个派生)batch import
area/tracingenhancementhelp wanted

仓库指标

星标
 (27,997 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

Description: Envoy adds an error tag to trace when HTTP status is 5xx (NOT when HTTP status is 4xx). On the other hand, envoy adds an error tag to trace when GRPC status is not "OK".

I think envoy should not adds an error tag to trace when GRPC status is such as "NOT_FOUND" or "PERMISSION_DENIED" because they are equivalent to HTTP status 4xx.

Is there any intention for this difference?

Relevant Links: https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/observability/tracing#what-data-each-trace-contains

贡献者指南