envoyproxy/envoy

Prevent addition of redundant protobuf imports

Open

#15,589 创建于 2021年3月20日

在 GitHub 查看
 (2 评论) (0 反应) (1 负责人)C++ (5,373 fork)batch import
area/buildhelp wanted

仓库指标

Star
 (27,997 star)
PR 合并指标
 (平均合并 8天) (30 天内合并 378 个 PR)

描述

description

we have a lot of redundant import warnings when generating protos

i have raised a pr to fix this upstream in cncf/xds (https://github.com/cncf/xds/pull/3)

i have previously removed them from the envoy codebase (#15329 ) and have just opened another PR to remove more recently added ones (#15588 )

it would be great if we prevented these from being added

the obvious way would be to turn warnings into errors (see https://github.com/protocolbuffers/protobuf/issues/3980)

the problem with this is that there are a lot of warnings about missing dir paths which i think is harder to fix (https://github.com/bazelbuild/bazel/issues/7157)

贡献者指南