envoyproxy/envoy

Unify URL parsing with GoogleURL

Open

#15,290 创建于 2021年3月3日

在 GitHub 查看
 (1 评论) (1 反应) (1 负责人)C++ (5,373 fork)batch import
area/httparea/securityhelp wanted

仓库指标

Star
 (27,997 star)
PR 合并指标
 (平均合并 8天) (30 天内合并 378 个 PR)

描述

Two concerns:

  • llhttp (http-parser replacement) does not have a URL parser: https://github.com/nodejs/llhttp/issues/7. Derek brought up this concern in that issue.
  • The fewer different URL parsing stuff we have, the better.

Envoy uses http_parser_url to split the URL into pieces.

We should replace this with GoogleURL, which does URL parsing (https://chromium.googlesource.com/chromium/src/+/master/url#parsing). See https://chromium.googlesource.com/chromium/src/+/master/url/gurl.h#340

Related Issues: https://github.com/envoyproxy/envoy/issues/5155 https://github.com/envoyproxy/envoy/issues/6588

Can we bring back https://github.com/envoyproxy/envoy/pull/11670?

cc @derekargueta @dio @envoyproxy/security-team

贡献者指南