Router: Audit ASSERTs · envoyproxy/envoy#14961 | Good First Issue

(2 评论) (0 反应) (0 负责人)C++ (5,373 fork)batch import

area/securityhelp wanted

仓库指标

Star: (27,997 star)
PR 合并指标: (平均合并 8天) (30 天内合并 378 个 PR)

描述

This issue describes a scan of ASSERTs in the router filter and recommendations to change some: https://gist.github.com/asraa/859a41a8f5f252d35da58c9ef7502230

Those marked with a verdict have been audited or unknown if they need a pair of eyes.

Change 1 refactorable call https://github.com/envoyproxy/envoy/blob/488973532ac72f56473bd2b6f770f0a011bf14a1/source/common/router/router.cc#L276 add check for scheme headers during filter processing https://github.com/envoyproxy/envoy/blob/488973532ac72f56473bd2b6f770f0a011bf14a1/source/common/router/router.cc#L566
Audit
- https://github.com/envoyproxy/envoy/blob/488973532ac72f56473bd2b6f770f0a011bf14a1/source/common/router/router.cc#L653

贡献者指南

研究方向: 查看位于 https://gist.github.com/asraa/859a41a8f5f252d35da58c9ef7502230 的要点，其中描述了 ASSERT 审计。主要修改的文件是 source/common/router/router.cc，具体行号为：276、566 和 653。任务涉及在过滤器处理期间添加对 scheme 头部的检查，并审计标记的其他 ASSERT。检查这些行周围的代码以理解当前的断言逻辑，并应用建议的更改。没有关联的 PR，因此实现是独立的。
技术栈: cpp
领域: backendinfrastructure
议题类型: 重构
难度: 3
预计时间: 1-2 天
活动状态: 活跃
清晰度: 清晰
前置要求: C++Envoy internals
新手友好度: 40