Remove unused methods and exceptions from JsonObject · envoyproxy/envoy#14893 | Good First Issue

(0 评论) (0 反应) (0 负责人)C++ (5,373 fork)batch import

help wantedtech debt

仓库指标

Star: (27,997 star)
PR 合并指标: (平均合并 8天) (30 天内合并 378 个 PR)

描述

Remove instance of loadFromString in header formatter and replace with protobuf . https://github.com/envoyproxy/envoy/blob/e073b325890542a3ce3bbc4eefb89a09f390f27e/source/common/router/header_formatter.cc#L61
Remove unused methods and the unsafe code that can throw exceptions such as the get[Type] methods that don't have defaults. https://github.com/envoyproxy/envoy/blob/0d5b470097d5e3645759e43414db8a7104aafb2e/include/envoy/json/json_object.h#L114

Follow-up to https://github.com/envoyproxy/envoy/pull/14467

贡献者指南

研究方向: 从header formatter.cc中移除loadFromString方法，并用protobuf替换。然后移除json object.h中可能抛出异常的get[Type]方法。
技术栈: cpp
领域: backend
议题类型: 重构
难度: 2
预计时间: 1-3 小时
活动状态: 活跃
清晰度: 清晰
前置要求: GitC++
新手友好度: 80