envoyproxy/envoy

feature: Cluster level HTTP health check port setting

Open

#14,045 创建于 2020年11月16日

在 GitHub 查看
 (9 评论) (2 反应) (0 负责人)C++ (5,373 fork)batch import
area/health_checkinghelp wanted

仓库指标

Star
 (27,997 star)
PR 合并指标
 (平均合并 8天) (30 天内合并 378 个 PR)

描述

Description: There's currently a configuration option within config.endpoint.v3.Endpoint.HealthCheckConfig for overriding the port_value.

The issue with this, or rather, the inconvenience, is that this is configurable per-endpoint. Ideally, we'd have the ability to configure this also at the cluster config.core.v3.HealthCheck level as well, with the current setting operating as an override if there is no cluster level setting set. This would work (assumingly) identical to the hostname value inside of the HealthCheckConfig today based on it's documentation:

By default, the host header for L7 health checks is controlled by cluster level configuration (see: host and authority). Setting this to a non-empty value allows overriding the cluster level configuration for a specific endpoint.

贡献者指南