envoyproxy/envoy

requests failed "above" EDS level should be reflected in load reporting

Open

#13,206 创建于 2020年9月21日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)C++ (5,373 fork)batch import
area/cluster_managerbughelp wanted

仓库指标

Star
 (27,997 star)
PR 合并指标
 (平均合并 8天) (30 天内合并 378 个 PR)

描述

There are at least a couple of cases where Envoy will fail requests "above" the EDS layer:

  • When the EDS resource does not exist.
  • When the cluster fails requests due to maintenance mode.

In these cases, the failed requests don't show up in LRS load reporting at all. I think this should be changed to report these as failed requests in an UpstreamLocalityStats message that does not have the locality field populated. This representation seems compatible with how we report stats for non-EDS clusters (e.g., LOGICAL_DNS clusters).

CC @htuch

贡献者指南