envoyproxy/envoy

Clean up proliferation of std::chrono duration types

Open

#12,384 创建于 2020年7月30日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)C++ (5,373 fork)batch import
help wantedtech debt

仓库指标

Star
 (27,997 star)
PR 合并指标
 (平均合并 8天) (30 天内合并 378 个 PR)

描述

https://github.com/envoyproxy/envoy/pull/12225 ensured that arbitrary std::chrono::{clock_type}::duration constructors cannot be used as it introduces differences in time representation/units between different platforms. @lizan suggested also ensuring that TimeSystem (used in test infrastructure) should provide a concrete duration type to reduce the proliferation of std::chrono duration types. Concrete duration aliases were added in that class but all usages of std::chrono duration types are not yet converted to TimeSystem::Nanosecond etc.

This issue is a placeholder to denote that std::chrono duration types should be replaced with TimeSystem aliases and introduce a format check to prevent their re-addition in the future.

贡献者指南