envoyproxy/envoy

feature req: SQL codecs need to inject or parse trace headers from comments

Open

#11,718 创建于 2020年6月23日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)C++ (5,373 fork)batch import
enhancementhelp wanted

仓库指标

Star
 (27,997 star)
PR 合并指标
 (平均合并 8天) (30 天内合并 378 个 PR)

描述

Having the ability to trace database calls is very useful. Imagine the following example flow:

app---(sql query)-->sidecar--->DB

if app sends SQL queries with the trace headers as SQL comments, then the sidecar can emit client-side trace spans, recording the DB call durations. [The more industrious lot can parse DB query logs to extract trace headers and emit server side spans?]

if app doesn't send the trace headers as comments, the sidecar can still inject them (it will be a broken trace, but a trace nevertheless).

I am not sure if mongodb supports comments - the same can be done for mongo as well.

贡献者指南